Comments on: Sending HTML & TXT Email at the send time http://code.lewro.com/php/sending-html-txt-email-at-the-send-time/ Code & Config - sharing the smart bits Mon, 29 Aug 2011 01:51:45 +0000 hourly 1 http://wordpress.org/?v=3.2.1 By: admin http://code.lewro.com/php/sending-html-txt-email-at-the-send-time/comment-page-1/#comment-23 admin Thu, 28 Jan 2010 22:33:15 +0000 http://code.lewro.com/?p=127#comment-23 Looks great @Griff. Good call with those variables. I put the code together from various sources and that's where the mixture of variables come from. Let me fix that. Looks great @Griff.
Good call with those variables. I put the code together from various sources and that’s where the mixture of variables come from. Let me fix that.

]]> By: Griff http://code.lewro.com/php/sending-html-txt-email-at-the-send-time/comment-page-1/#comment-22 Griff Thu, 28 Jan 2010 22:18:26 +0000 http://code.lewro.com/?p=127#comment-22 Good work! I think this could be made really useful by making it a more general function: something like (I'm just sketching the idea here) [php] function send_html_and_text_email( $to, $from, $subject, $htmlContent, $textContent = ""){ // $to could be an array or a single email, the function would be able // to deal with it using the is_array function // The text half of the email, if the parameter is empty, could be extracted // from the html content, by extracting everything between the <body> tags // with a regex and then running strip_tags on that } [/php] Like I say, it's just a sketch, but could be a really useful library function :) Also, one thing I can't help but note from your code is the mix of Camel Case and underscore convention for naming variables, sometimes even within the same identifier - that's a bit mental :P Good work! I think this could be made really useful by making it a more general function: something like (I’m just sketching the idea here)

function send_html_and_text_email( $to, $from, $subject, $htmlContent, $textContent = ""){

// $to could be an array or a single email, the function would be able
// to deal with it using the is_array function

// The text half of the email, if the parameter is empty, could be extracted
// from the html content, by extracting everything between the <body> tags
// with a regex and then running strip_tags on that

}

Like I say, it’s just a sketch, but could be a really useful library function :)

Also, one thing I can’t help but note from your code is the mix of Camel Case and underscore convention for naming variables, sometimes even within the same identifier – that’s a bit mental :P

]]>